improve error message for using property of type as type #45354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ~~~ | ||
| !!! error TS2694: Namespace 'Color' has no exported member 'Red'. | ||
| ~~~~~~~~ | ||
| !!! error TS2713: Cannot access 'Red.toString' because 'Red' is a type, but not a namespace. Did you mean to retrieve the type of the property 'toString' in 'Red' with 'Red["toString"]'? |
There was a problem hiding this comment.
I think we'd really like to suggest typeof Color.Red.toString first if that would be valid, then fall back to using indexed access syntax.
andrewbranch
approved these changes
Sep 2, 2021
DanielRosenwasser
requested changes
Sep 2, 2021
Zzzen
commented
Sep 3, 2021
src/compiler/checker.ts
Outdated
| error(right, Diagnostics._0_has_no_exported_member_named_1_Did_you_mean_2, namespaceName, declarationName, symbolToString(suggestionForNonexistentModule)); | ||
| } | ||
| else if (canSuggestTypeof) { | ||
| error(name, Diagnostics._0_refers_to_a_value_but_is_being_used_as_a_type_here_Did_you_mean_typeof_0, entityNameToString(fullQualifiedName as QualifiedName)); |
There was a problem hiding this comment.
Haven't tried TypeScript 4.4, so I wrote fullQualifiedName as QualifiedName. After upgrading vscode, I find it is unnecessary. The CFA is really impressive, kudos to you guys!
DanielRosenwasser
approved these changes
Sep 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45333