fix issue where duplicate default exports aren't detected #46871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We'll definitely want a testcase or two. This stuff is very easy to unintentionally break when modifying the binder. |
Contributor
Author
|
@RyanCavanaugh done |
sandersn
requested changes
Jan 28, 2022
sandersn
approved these changes
Feb 2, 2022
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
This looks plausible to me, but let's hold it until after 4.6 RC is out so that we have all of 4.7 to let people test it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #46865