Fix JSX inference with excess properties

[Andarist]

fixes #53789

it's basically the same fix as the one here, just applied to JSX

[jakebailey]

This feels accurate but @weswigham probably knows better

[Andarist]

@jakebailey any chance of landing this into the just started 5.2? :)

[jakebailey]

This PR is 100 commits behind main at this point, but let me close/reopen just to recheck CI. That and

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 98d4243. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 98d4243. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 98d4243. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 98d4243. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 98d4243. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53810

Metric	main	53810	Delta	Best	Worst	p-value
Angular - node (v16.17.1, x64)
Memory used	365,059k (± 0.01%)	365,055k (± 0.01%)	~	364,989k	365,119k	p=0.936 n=6
Parse Time	3.55s (± 0.58%)	3.56s (± 0.90%)	~	3.52s	3.60s	p=0.627 n=6
Bind Time	1.18s (± 0.69%)	1.19s (± 0.63%)	~	1.18s	1.20s	p=0.383 n=6
Check Time	9.63s (± 0.49%)	9.62s (± 0.40%)	~	9.57s	9.68s	p=0.688 n=6
Emit Time	7.95s (± 0.86%)	7.93s (± 0.52%)	~	7.88s	8.00s	p=0.573 n=6
Total Time	22.32s (± 0.40%)	22.30s (± 0.37%)	~	22.21s	22.42s	p=0.810 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	192,896k (± 0.03%)	192,895k (± 0.04%)	~	192,834k	193,014k	p=0.810 n=6
Parse Time	1.60s (± 1.99%)	1.61s (± 0.64%)	~	1.59s	1.62s	p=0.935 n=6
Bind Time	0.83s (± 0.62%)	0.83s (± 0.62%)	~	0.82s	0.83s	p=1.000 n=6
Check Time	10.13s (± 0.34%)	10.17s (± 0.81%)	~	10.04s	10.26s	p=0.297 n=6
Emit Time	2.99s (± 0.56%)	3.01s (± 0.68%)	~	2.99s	3.05s	p=0.059 n=6
Total Time	15.54s (± 0.27%)	15.62s (± 0.66%)	~	15.45s	15.73s	p=0.126 n=6
Monaco - node (v16.17.1, x64)
Memory used	345,849k (± 0.00%)	345,864k (± 0.00%)	+16k (+ 0.00%)	345,845k	345,877k	p=0.031 n=6
Parse Time	2.72s (± 0.28%)	2.74s (± 0.36%)	+0.02s (+ 0.73%)	2.73s	2.75s	p=0.010 n=6
Bind Time	1.09s (± 1.13%)	1.08s (± 0.50%)	~	1.08s	1.09s	p=0.441 n=6
Check Time	7.78s (± 0.38%)	7.82s (± 0.57%)	~	7.77s	7.89s	p=0.091 n=6
Emit Time	4.44s (± 0.40%)	4.45s (± 0.92%)	~	4.41s	4.53s	p=0.745 n=6
Total Time	16.02s (± 0.27%)	16.11s (± 0.35%)	+0.08s (+ 0.50%)	16.03s	16.18s	p=0.030 n=6
TFS - node (v16.17.1, x64)
Memory used	299,956k (± 0.00%)	299,974k (± 0.01%)	~	299,950k	300,005k	p=0.128 n=6
Parse Time	2.17s (± 0.63%)	2.17s (± 0.54%)	~	2.16s	2.19s	p=0.506 n=6
Bind Time	1.24s (± 0.66%)	1.25s (± 0.71%)	+0.01s (+ 1.08%)	1.24s	1.26s	p=0.038 n=6
Check Time	7.28s (± 0.24%)	7.29s (± 0.24%)	~	7.26s	7.30s	p=0.626 n=6
Emit Time	4.31s (± 0.88%)	4.34s (± 0.90%)	~	4.31s	4.41s	p=0.124 n=6
Total Time	14.99s (± 0.28%)	15.05s (± 0.31%)	~	15.00s	15.13s	p=0.089 n=6
material-ui - node (v16.17.1, x64)
Memory used	480,960k (± 0.00%)	480,938k (± 0.00%)	-22k (- 0.00%)	480,919k	480,964k	p=0.020 n=6
Parse Time	3.25s (± 0.32%)	3.26s (± 0.57%)	~	3.24s	3.29s	p=0.406 n=6
Bind Time	0.94s (± 0.80%)	0.94s (± 0.55%)	~	0.94s	0.95s	p=0.784 n=6
Check Time	17.79s (± 0.46%)	17.99s (± 1.38%)	~	17.73s	18.32s	p=0.229 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	21.98s (± 0.39%)	22.19s (± 1.19%)	~	21.92s	22.53s	p=0.199 n=6
xstate - node (v16.17.1, x64)
Memory used	560,538k (± 0.03%)	560,436k (± 0.01%)	~	560,334k	560,556k	p=0.173 n=6
Parse Time	4.00s (± 0.37%)	4.02s (± 0.19%)	+0.02s (+ 0.42%)	4.01s	4.03s	p=0.042 n=6
Bind Time	1.76s (± 0.59%)	1.76s (± 0.69%)	~	1.75s	1.78s	p=0.337 n=6
Check Time	3.07s (± 0.70%)	3.07s (± 0.50%)	~	3.05s	3.08s	p=0.675 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	8.92s (± 0.43%)	8.95s (± 0.24%)	~	8.92s	8.98s	p=0.296 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-148-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• Angular - node (v16.17.1, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Monaco - node (v16.17.1, x64)
• TFS - node (v16.17.1, x64)
• material-ui - node (v16.17.1, x64)
• xstate - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	53810	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53810/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Unknown failure"
• 1 instance of "Package install failed"

Otherwise...

Everything looks good!

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53810/merge:

Everything looks good!

[typescript-bot]

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

[jakebailey]

FWIW back when I reviewed this last month, I did go do the git history checking to verify, and it is effectively the same fix and the new flag that's used instead now (compared to that old PR) would have been updated too, so, this to me seems sound (but I've already said that).