[experiment] error on module when namespace would work

[jakebailey]

This is just #58007 but with a hard error.

[jakebailey]

@typescript-bot test top800
@typescript-bot user test this
@typescript-bot run dt

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
test top800	✅ Started	👀 Results
user test this	✅ Started	👀 Results
run dt	✅ Started	✅ Results

[typescript-bot]

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

[typescript-bot]

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58040/merge:

Something interesting changed - please have a look.

Details

azure-sdk

/mnt/ts_downloads/_/m/azure-sdk/build.sh

• [NEW] error TS1499: A namespace declaration should not be declared using the module keyword. Please use the namespace keyword instead.
  • /mnt/ts_downloads/common/temp/node_modules/.pnpm/[email protected]/node_modules/rhea-promise/typings/lib/eventContext.d.ts(75,23)

[typescript-bot]

@jakebailey Here are the results of running the top 800 repos comparing main and refs/pull/58040/merge:

Something interesting changed - please have a look.

Details

Chocobozzz/PeerTube

5 of 11 projects failed to build with the old tsc and were ignored

packages/types-generator/tsconfig.types.json

• error TS1499: A namespace declaration should not be declared using the module keyword. Please use the namespace keyword instead.
  • server/core/types/models/user/user-notification.ts#L24 in server/tsconfig.types.json

packages/tests/tsconfig.json

• error TS1499: A namespace declaration should not be declared using the module keyword. Please use the namespace keyword instead.
  • server/core/types/models/user/user-notification.ts#L24 in server/tsconfig.lib.json

microsoft/azuredatastudio

8 of 67 projects failed to build with the old tsc and were ignored

build/tsconfig.build.json

• error TS1499: A namespace declaration should not be declared using the module keyword. Please use the namespace keyword instead.
  • build/lib/i18n.ts#L79
  • build/lib/i18n.ts#L92
  • build/lib/nls.ts#L100
  • build/lib/tsb/utils.ts#L6
  • build/lib/tsb/utils.ts#L46
  • build/lib/tsb/utils.ts#L63

microsoft/vscode

4 of 54 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

• error TS1499: A namespace declaration should not be declared using the module keyword. Please use the namespace keyword instead.
  • src/vs/editor/standalone/browser/standaloneServices.ts#L1134
  • src/vs/platform/extensionManagement/node/extensionSignatureVerificationService.ts#L32
  • src/vs/platform/sign/browser/signService.ts#L14
  • src/vs/platform/sign/node/signService.ts#L9
  • src/vs/server/node/remoteExtensionHostAgentServer.ts#L46
  • src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts#L22
  • src/vs/workbench/contrib/tasks/common/problemMatcher.ts#L36
  • src/vs/workbench/contrib/tasks/common/problemMatcher.ts#L58
  • src/vs/workbench/contrib/tasks/common/problemMatcher.ts#L120

src/tsconfig.monaco.json

• error TS1499: A namespace declaration should not be declared using the module keyword. Please use the namespace keyword instead.
  • src/vs/editor/standalone/browser/standaloneServices.ts#L1134
  • src/vs/platform/sign/browser/signService.ts#L14

src/tsconfig.json

• error TS1499: A namespace declaration should not be declared using the module keyword. Please use the namespace keyword instead.
  • src/vs/editor/standalone/browser/standaloneServices.ts#L1134
  • src/vs/platform/extensionManagement/node/extensionSignatureVerificationService.ts#L32
  • src/vs/platform/sign/browser/signService.ts#L14
  • src/vs/platform/sign/node/signService.ts#L9
  • src/vs/server/node/remoteExtensionHostAgentServer.ts#L46
  • src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts#L22
  • src/vs/workbench/contrib/tasks/common/problemMatcher.ts#L36
  • src/vs/workbench/contrib/tasks/common/problemMatcher.ts#L58
  • src/vs/workbench/contrib/tasks/common/problemMatcher.ts#L120

build/tsconfig.build.json

• error TS1499: A namespace declaration should not be declared using the module keyword. Please use the namespace keyword instead.
  • build/lib/i18n.ts#L68
  • build/lib/i18n.ts#L81
  • build/lib/nls.ts#L100
  • build/lib/tsb/utils.ts#L6
  • build/lib/tsb/utils.ts#L46
  • build/lib/tsb/utils.ts#L63

streetwriters/notesnook

11 of 20 projects failed to build with the old tsc and were ignored

packages/clipper/tsconfig.json

• error TS1499: A namespace declaration should not be declared using the module keyword. Please use the namespace keyword instead.
  • packages/clipper/src/index.global.ts#L21

TypeStrong/typedoc

1 of 5 projects failed to build with the old tsc and were ignored

src/test/renderer/testProject/tsconfig.json

• error TS1499: A namespace declaration should not be declared using the module keyword. Please use the namespace keyword instead.
  • src/test/renderer/testProject/src/access.ts#L59
  • src/test/renderer/testProject/src/enumerations.ts#L61
  • src/test/renderer/testProject/src/functions.ts#L150
  • src/test/renderer/testProject/src/modules.ts#L4
  • src/test/renderer/testProject/src/modules.ts#L23
  • src/test/renderer/testProject/src/modules.ts#L34
  • src/test/renderer/testProject/src/modules.ts#L34

src/test/converter/tsconfig.json

• error TS1499: A namespace declaration should not be declared using the module keyword. Please use the namespace keyword instead.
  • src/test/converter/class/class.ts#L109
  • src/test/converter/enum/enum.ts#L44
  • src/test/converter/function/function.ts#L164
  • src/test/converter/interface/interface-implementation.ts#L1

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

• error TS1499: A namespace declaration should not be declared using the module keyword. Please use the namespace keyword instead.
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L3 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L4 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L343 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L660 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L1118 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L1279 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L1381 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L1811 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L3094 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L3291 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L3380 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L4709 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L4913 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L4950 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L5488 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L5571 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L5646 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L5680 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L6244 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L6324 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L6392 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L6771 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L7294 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L7330 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L7627 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L7740 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L7888 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L10200 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L11023 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L12892 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L12969 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L13061 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L13366 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L13493 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L14353 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L14577 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L15021 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L15061 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L15278 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L15651 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L15888 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L16158 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L16285 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L16347 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L16525 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L16633 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L16702 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L17687 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L17912 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L18182 in tsconfig.json
  • file:///mnt/ts_downloads/_/m/hyper/node_modules/playwright-core/types/protocol.d.ts#L19233 in tsconfig.json