autoimports checks for merged parent if symbol parent is not found #59582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
This was referenced Aug 9, 2024
Andarist
reviewed
Aug 10, 2024
| addImport(first(info)); | ||
| } | ||
|
|
||
| function getExportedSymbolParent(symbol: Symbol, checker: TypeChecker): Symbol { |
Contributor
There was a problem hiding this comment.
I wonder if this is something that will only be relevant for import fixes. Could any other code crash similarly due to a missing parent?
Member
There was a problem hiding this comment.
It would be nice/convenient if the checker set the parent, but I thought it was better not to touch the checker and add a bunch of parent pointers to everyone’s program if tsc never needs them. We could try it and see if it shows up in the perf run. At least, we should have a comment here explaining that this function is making up for an arguable checker deficiency.
Member
Author
|
closed by #59609 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to
importFixes/autoimports that finds the parent ifsymbol.parentdoes not exist.When merging symbols that are exported through export lists and then augmented in module augmentations (for example, interfaces), the merged symbol does not have a parent. The augmentations work correctly with the merged symbols not having parents. Since the parent is not needed for typechecking and seems to only be needed in this case of autoimports, we will save memory by continuing to not set
.parent. (we can revisit this if we see.parentis needed elsewhere in the future).Fixes #58907
Closes #58965 (more info in comment)
(the aliased case mentioned here still crashes but because of a different autoimports bug, so opened up a new issue: #59583)