Skip to content

Python: default to service managed threads for AzureAIAgentClient to prevent … #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Python: default to service managed threads for AzureAIAgentClient to prevent … #1690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4298b2e
default to service managed threads for AzureAIAgentClient to prevent …
Oct 24, 2025
7ce75b2
Merge branch 'main' into alexlavaee/feature/ai-foundry-client-defaults
lavaman131 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion python/packages/azure-ai/agent_framework_azure_ai/_chat_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import os
import sys
from collections.abc import AsyncIterable, MutableMapping, MutableSequence, Sequence
from typing import Any, ClassVar, TypeVar
from typing import TYPE_CHECKING, Any, ClassVar, TypeVar

from agent_framework import (
AGENT_FRAMEWORK_USER_AGENT,
Expand Down Expand Up @@ -98,6 +98,9 @@
else:
from typing_extensions import Self # pragma: no cover

if TYPE_CHECKING:
from agent_framework import ChatAgent


logger = get_logger("agent_framework.azure")

Expand Down Expand Up @@ -1102,3 +1105,6 @@ def service_url(self) -> str:
The service URL for the chat client, or None if not set.
"""
return self.project_client._config.endpoint

def create_agent(self, *, store: bool | None = True, **kwargs: Any) -> "ChatAgent":
Copy link
Member

@eavanvalkenburg eavanvalkenburg Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is the way, for one, this method lacks all metadata compared to the create_agent method on the BaseClient, so it won't give the right IDE info. It also introduces a difference in creating a agent through this method, vs directly, which I don't like. I'm also not convinced what problem this solves.

return super().create_agent(store=store, **kwargs)