Skip to content

Migrate DownloadGitHubNpmPackageV1 task to Node10 #16019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 15, 2022
Merged

Migrate DownloadGitHubNpmPackageV1 task to Node10 #16019

merged 5 commits into from
Jul 15, 2022

Conversation

@mr-dokara
Copy link
Contributor

@mr-dokara mr-dokara commented Mar 10, 2022 •
edited
Loading

Task name: DownloadGitHubNpmPackageV1

Description: Migrated DownloadGitHubNpmPackageV1 task to Node10.

Documentation changes required: N

Added unit tests: N

Attached related issue: N

Checklist:

  • Task version was bumped
  • Checked that applied changes work as expected

@mr-dokara mr-dokara requested a review from harshiniks as a code owner March 10, 2022 17:38
@mr-dokara mr-dokara mentioned this pull request Mar 10, 2022
Closed
39 tasks
@mr-dokara mr-dokara requested review from a team and mmrazik March 10, 2022 19:26
@mr-dokara
Copy link
Contributor Author

mr-dokara commented Mar 10, 2022 •
edited
Loading

Tested manually, everything works fine

@mr-dokara
Copy link
Contributor Author

mr-dokara commented Mar 10, 2022

Hi @harshiniks, Could you please take a look at this PR?

@mpodriezov
Merge branch 'master' of github.com:microsoft/azure-pipelines-tasks i…
9bb93ab 
…nto users/golubev-ivan/migrate-downloadgithubnpmpackage-task-to-node10
@mr-dokara mr-dokara requested a review from v-nmursapall as a code owner June 27, 2022 10:17
@mpodriezov
Copy link
Contributor

mpodriezov commented Jun 27, 2022

  • Merged conflicts with master
  • removed request library as it is not used, this fixed all CG bugs
  • bumped the version in task.json

@mpodriezov
Copy link
Contributor

mpodriezov commented Jun 27, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 27, 2022

Azure Pipelines successfully started running 4 pipeline(s).

@mpodriezov
Copy link
Contributor

mpodriezov commented Jul 13, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 13, 2022

Azure Pipelines successfully started running 4 pipeline(s).

v-nmursapall
v-nmursapall approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@v-nmursapall v-nmursapall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine.

@mpodriezov
Copy link
Contributor

mpodriezov commented Jul 15, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 15, 2022

Azure Pipelines successfully started running 4 pipeline(s).

@mpodriezov mpodriezov merged commit 0ee7b4d into master Jul 15, 2022
@localconst localconst mentioned this pull request Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshiniks harshiniks Awaiting requested review from harshiniks

@mmrazik mmrazik Awaiting requested review from mmrazik

3 more reviewers

@alexander-smolyakov alexander-smolyakov alexander-smolyakov approved these changes

@v-nmursapall v-nmursapall v-nmursapall approved these changes

@denis-tikhomirov denis-tikhomirov denis-tikhomirov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mr-dokara @mpodriezov @alexander-smolyakov @v-nmursapall @denis-tikhomirov