Skip to content

Guarantee pipeline failure for AzurePowerShellV5 #21377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Guarantee pipeline failure for AzurePowerShellV5 #21377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1f20926
Guarantee pipeline failure for AzurePowerShellV5
tpavlovi Oct 12, 2025
551bc88
Added cleanupExitCode
tpavlovi Oct 12, 2025
c398977
added logs
tpavlovi Oct 12, 2025
0e447b4
added try-catch
tpavlovi Oct 12, 2025
459dd96
removed logs
tpavlovi Oct 12, 2025
a60c59b
added logs
tpavlovi Oct 12, 2025
4ddd51d
changed condition
tpavlovi Oct 12, 2025
63332c3
Uncommented the fix for the missing import error
tpavlovi Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions Tasks/AzurePowerShellV5/RemoveAzContext.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,21 @@
Import-Module "$PSScriptRoot\ps_modules\VstsTaskSdk" -ArgumentList @{ NonInteractive = $true }

. "$PSScriptRoot/Utility.ps1"
. "$PSScriptRoot/ps_modules/VstsAzureHelpers_/Utility.ps1"
Set-StrictMode -Version Latest
$ErrorActionPreference = 'Stop'
try {
. "$PSScriptRoot/Utility.ps1"
. "$PSScriptRoot/ps_modules/VstsAzureHelpers_/Utility.ps1"

Update-PSModulePathForHostedAgentLinux
Disconnect-AzureAndClearContext -restrictContext 'True'
Update-PSModulePathForHostedAgentLinux
Disconnect-AzureAndClearContext -restrictContext 'True'

if ($env:AZURESUBSCRIPTION_SERVICE_CONNECTION_ID) {
$env:AZURESUBSCRIPTION_SERVICE_CONNECTION_ID = ""
$env:AZURESUBSCRIPTION_CLIENT_ID = ""
$env:AZURESUBSCRIPTION_TENANT_ID = ""
if ($env:AZURESUBSCRIPTION_SERVICE_CONNECTION_ID) {
$env:AZURESUBSCRIPTION_SERVICE_CONNECTION_ID = ""
$env:AZURESUBSCRIPTION_CLIENT_ID = ""
$env:AZURESUBSCRIPTION_TENANT_ID = ""
}
}
catch {
Write-Host "##vso[task.logissue type=error]$($_.Exception.Message)"
exit 1
}
8 changes: 7 additions & 1 deletion Tasks/AzurePowerShellV5/azurepowershell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ async function run() {
tl.setResult(tl.TaskResult.Failed, err.message || 'run() failed');
}
finally {
let cleanupExitCode = 0;
try {
const powershell = tl.tool(tl.which('pwsh') || tl.which('powershell') || tl.which('pwsh', true))
.arg('-NoLogo')
Expand All @@ -197,10 +198,15 @@ async function run() {
outStream: process.stdout, // of order since Node buffers it's own STDOUT but not STDERR.
ignoreReturnCode: true
};
await powershell.exec(options);
cleanupExitCode = await powershell.exec(options);
tl.debug(`Cleanup exit code: ${cleanupExitCode}`);
}
catch (err) {
tl.debug("Az-clearContext not completed due to an error");
tl.setResult(tl.TaskResult.Failed, err.message);
}
if (cleanupExitCode !== 0) {
tl.setResult(tl.TaskResult.Failed, `Cleanup failed with exit code ${cleanupExitCode}`);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion Tasks/AzurePowerShellV5/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"version": {
"Major": 5,
"Minor": 264,
"Patch": 0
"Patch": 1
},
"releaseNotes": "Added support for Az Module and cross platform agents.",
"groups": [
Expand Down
2 changes: 1 addition & 1 deletion Tasks/AzurePowerShellV5/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"version": {
"Major": 5,
"Minor": 264,
"Patch": 0
"Patch": 1
},
"releaseNotes": "ms-resource:loc.releaseNotes",
"groups": [
Expand Down