chore: add test:compat to CI tests #3691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hooray! The last build failed, just like it should. |
mdrichardson
commented
May 14, 2021
mdrichardson
commented
May 14, 2021
mdrichardson
commented
May 14, 2021
mdrichardson
commented
May 15, 2021
libraries/botbuilder-dialogs-declarative/src/resources/resourceExplorer.ts
Outdated
Show resolved
Hide resolved
mdrichardson
commented
May 15, 2021
libraries/botbuilder-dialogs-declarative/src/resources/resourceProvider.ts
Outdated
Show resolved
Hide resolved
mdrichardson
commented
May 15, 2021
Pull Request Test Coverage Report for Build 858282743
💛 - Coveralls |
mdrichardson
requested review from
a team,
joshgummersall and
stevengum
as code owners
joshgummersall
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3632
Adds
test:compatto CI. Should fail the CI test ifapi-extractorgenerates a diff.Notes
...api.mdfile diffs seem fine, but might be worth a closer look as there's a small number of public methods/interfaces that show diffs.node 10.xruns. This is roughly load-balanced since each node version in CI now runs two version-specific tasks.For developers who stumbled here after your CI tests failed
yarn buildyarn test:compatapi.mdinlibraries/<failing lib>/tempand copy it tolibraries/<failing lib>/etc, then commit the changes.