wait for volume attachments to be detached before deleting a vm #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgel-ms
requested review from
nwoodmsft,
pradipd and
zawachte
as code owners
georgel-ms
force-pushed
the
georgel-fix-volumedetach
branch
2 times, most recently
from
da44baa to
10b3f10
Compare
georgel-ms
changed the title
georgel-ms
force-pushed
the
georgel-fix-volumedetach
branch
from
10b3f10 to
bdf532c
Compare
Contributor
|
CAPI is already supposed to wait for the PVs to be detached before scheduling node delete. |
zawachte
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a bug that during workload cluster upgrade, it takes long time to wait for the PV to attach to the new node, we may see multiple errors like this:
I0404 11:45:49.477443 1 event.go:307] "Event occurred" object="default/sample-dddf7bd5-wglbx" fieldPath="" kind="Pod" apiVersion="v1" type="Warning" reason="FailedAttachVolume" message="Multi-Attach error for volume "pvc-d0cec9c7-7d3a-4961-ab35-7bda48cbe5ee" Volume is already used by pod(s) sample-dddf7bd5-7rh7q"
In this PR, we intentionally wait for the PV to detach from the old node before the vm is deleted to avoid the above error.