This repository was archived by the owner on May 20, 2025. It is now read-only.
Release table header changes #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
lostintangent
added a commit
that referenced
this pull request
Jan 21, 2016
Release table header changes
richardhuaaa
pushed a commit
that referenced
this pull request
Jan 26, 2016
Remove DeploymentKey object and fetch key directly off Deployments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply changes the names of two headers in the deployment and release history, and ensures that the number of pending installs is greater than zero before showing it. For the later, we should investigate why this number would become negative, but in the meantime, it seems semantically correct to explicitly verify that we want a positive number anyways.