This repository was archived by the owner on May 20, 2025. It is now read-only.
Move name resolution logic out of the CLI #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| function throwForInvalidApp(app: App, appName: string): void { |
There was a problem hiding this comment.
Verify that error messages are unchanged - as we are resolving names on the server, an invalid name will result in an error coming from the server rather than the CLI.
There was a problem hiding this comment.
I will need to add this as part of a server change - currently we just get:
[Error] Not Found
|
Looks good. |
richardhuaaa
pushed a commit
that referenced
this pull request
Feb 17, 2016
…ification Move name resolution logic out of the CLI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Merging into 'breaking'. On the diff tab, add '?w=1' to the URL to ignore whitespace changes)
Note that the issue of disambiguating duplicate apps by email is not explicitly addressed here. I will address this in a subsequent review, but I expect that it will be a matter of URL encoding the '/appName' chunk and then decoding it on the server.