This repository was archived by the owner on May 20, 2025. It is now read-only.
Rely on server for generation of qualified app names #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| var dataSource: any[] = apps.map((app: App, index: number) => { | ||
| return { "name": getAppDisplayName(app, appNameToCountMap), "deployments": deploymentLists[index] }; | ||
| var augmentedApp: any = app; | ||
| augmentedApp.deployments = deploymentLists[index]; |
There was a problem hiding this comment.
Dont you need to return something?
There was a problem hiding this comment.
Thanks for catching this, big oversight on my part there.
|
LGTM otherwise! |
richardhuaaa
pushed a commit
that referenced
this pull request
Feb 20, 2016
Rely on server for generation of qualified app names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Merging into 'breaking')
The server now accepts qualified app names as input and also sends them as output where appropriate, so that this logic does not need to be performed by clients.
This will be the last set of breaking changes on the client (I didn't realize I needed to do this when I sent the wrap-up PR yesterday)