Skip to content

fix: catch PackagesConfigReaderException in NuGetPackagesConfigDetector #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2022
Merged

fix: catch PackagesConfigReaderException in NuGetPackagesConfigDetector #362

merged 2 commits into from
Nov 9, 2022

Conversation

@JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Nov 9, 2022

Additional fix on top of #360

@JamieMagee JamieMagee requested a review from a team as a code owner November 9, 2022 19:52
@JamieMagee JamieMagee requested a review from Omotola November 9, 2022 19:52
@JamieMagee
Copy link
Member Author

JamieMagee commented Nov 9, 2022

ubuntu and macos verification tests are failing due to updated components from packages.config. windows verification tests are still failing due to #353.

@JamieMagee JamieMagee merged commit 678bdff into main Nov 9, 2022
@JamieMagee JamieMagee deleted the users/jamagee/catch-packages-config-reader-exception branch November 9, 2022 22:52
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Omotola Omotola Awaiting requested review from Omotola Omotola is a code owner automatically assigned from microsoft/ose-component-detection-maintainers

1 more reviewer

@amitla1 amitla1 amitla1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JamieMagee @amitla1