Skip to content

Conversation

@melotic
Copy link
Member

@melotic melotic commented Mar 28, 2023

Closes #476

@github-actions
Copy link

github-actions bot commented Mar 28, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@melotic melotic marked this pull request as ready for review March 28, 2023 22:17
@melotic melotic requested a review from a team as a code owner March 28, 2023 22:17
@melotic melotic requested a review from Omotola March 28, 2023 22:17
@melotic
Copy link
Member Author

melotic commented Mar 28, 2023

Open questions for the NPM team:

  • We do not have access to the ancestors of a current node to determine if a component is nested into another one (i.e. node_modules/x/node_modules/y). So, we recursively find the shortest path to the root note to determine the ancestors. Is there a possibility for multiple paths back to the root node? Or if that's possible, will the component always be placed in the root? (i.e. node_modules/y)

@melotic melotic force-pushed the justinperez/npm-decereal branch from 978866b to 1326d24 Compare March 29, 2023 17:53
melotic added 3 commits March 30, 2023 15:13
# Conflicts:
#	src/Microsoft.ComponentDetection.Detectors/npm/NpmComponentDetectorWithRoots.cs
@melotic melotic merged commit 4c53d00 into main Apr 7, 2023
@melotic melotic deleted the justinperez/npm-decereal branch April 7, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for NPM lockfileVersion v3

3 participants