fix(stylelint-plugin): allow more pseudo classes #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ling1726
reviewed
Jul 3, 2025
| import { createRule } from '../../create-rule'; | ||
| import { normalizeRuleName } from '../../normalize-rule-name'; | ||
|
|
||
| const ALLOWED_PSEUDO_CLASSES = [':hover', ':active', ':focus', ':focus-within']; |
There was a problem hiding this comment.
could this be updated to a rule config to remove the dependency on a code release for users?
ling1726
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug in the
@fluentui-contrib/stylelint-pluginpackage by expanding the list of allowed pseudo-classes in the combinator depth rule. The changes ensure better compatibility with modern CSS practices.Bug Fix:
packages/stylelint-plugin/src/rules/combinator-depth/combinator-depth.ts: Introduced a constantALLOWED_PSEUDO_CLASSESto centralize the list of allowed pseudo-classes (:hover,:active,:focus,:focus-within) and updated the logic to use this constant when validating selectors. [1] [2]