Fix regression in useHoverState #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
changed the title
rurikoaraki
approved these changes
Oct 14, 2021
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
PR #1063 introduced a regression where the hook
useHoverStatewas not working properly. Thankfully this is only really used in test code, but we should fix it in case any clients use it. I also took the time to add some code comments + a link to the upstream Facebook issue of why we need to route onHoverIn & onHover out to onMouseEnter & onMouseLeaveVerification
Pressable Test works again
Screen.Recording.2021-10-14.at.5.17.16.PM.mov
Pull request checklist
This PR has considered (when applicable):