-
Notifications
You must be signed in to change notification settings - Fork 169
JSX runtime (part 2 of 3) - more formal rendering logic for both classic and new jsx runtimes #3947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Jul 25, 2025
Saadnajmi
reviewed
Jul 25, 2025
Saadnajmi
reviewed
Jul 25, 2025
Saadnajmi
reviewed
Jul 25, 2025
Saadnajmi
reviewed
Jul 25, 2025
NikoAri
approved these changes
Jul 25, 2025
rurikoaraki
approved these changes
Jul 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- with suggestions, which is apparently not an option with GH
Saadnajmi
approved these changes
Jul 28, 2025
JasonVMo
added a commit
that referenced
this pull request
Jul 29, 2025
…sic and new jsx runtimes (#3947) * rework jsx helpers for both new and old runtimes * implement both new and old render patterns for classic and jsx-runtimes * Change files * move package README.md files to be next to the source code * update documentation * Change files * prettier format updates to documentation * tweak documentation just a bit
JasonVMo
added a commit
that referenced
this pull request
Jul 29, 2025
…sic and new jsx runtimes (#3947) * rework jsx helpers for both new and old runtimes * implement both new and old render patterns for classic and jsx-runtimes * Change files * move package README.md files to be next to the source code * update documentation * Change files * prettier format updates to documentation * tweak documentation just a bit
JasonVMo
added a commit
that referenced
this pull request
Aug 5, 2025
…x-errors (#3948) * create a more robust depcheck implementation * fix missing eslint config dependencies * apply depcheck fix to directories to fix error level issues * fix missing deps for private packages * applying package updates * JSX runtime (part 2 of 3) - more formal rendering logic for both classic and new jsx runtimes (#3947) * rework jsx helpers for both new and old runtimes * implement both new and old render patterns for classic and jsx-runtimes * Change files * move package README.md files to be next to the source code * update documentation * Change files * prettier format updates to documentation * tweak documentation just a bit * applying package updates * apply more dependency fixes * JSX runtime (part 2 of 3) - more formal rendering logic for both classic and new jsx runtimes (#3947) * rework jsx helpers for both new and old runtimes * implement both new and old render patterns for classic and jsx-runtimes * Change files * move package README.md files to be next to the source code * update documentation * Change files * prettier format updates to documentation * tweak documentation just a bit * applying package updates * switch to pnpm and fix to build stage * fix dependencies up through linting * fix babel and jest configs and add dedicated babel config package * split jest configurations into a separate package * fix more tests * move repo to pnpm, create babel and jest config packages, fix dependencies * Change files * add missing @types/jest devDependency * fix ios/mac pod install * fix align-deps issue * fix more align-deps / depcheck issues * switch back to node-modules temporarily to deal with appium issues as a separate pr * add build fixes for node-modules linking * revert podfiles to non-pnpm behavior, fix prettier issues, respond to PR feedback --------- Co-authored-by: UI-Fabric-RN-Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This further centralizes the render logic and provides both classic and jsx-runtime implementations. It also does a few other things:
Verification
Builds, tests, bundling, running the testers and trying the controls. Also inspection of .tsx -> .js output as well as snapshot test results for render trees (which remain unchanged).
Other Notes
I will be creating unit tests as part of the final change where I turn on the new runtime. I need to figure out how to correctly unit test both classic and jsx scenarios at the same time.