High CPU Utilization from Gossip Fix

[vazois]

WIP

[Xizt]

Understanding the reason behind the connections being an array instead of something like a ConcurrentDictionary. Is it because the number of connections is expected to be significantly low to impact the search?

[vazois]

I feel that access should be pretty fast if the number of items is in the order of 100s - 1000s. The other issue is empirically we found that ConcurrentDictionary not being that performant. I guess since gossip is not on the critical path it should be fine. Last thing using our own lock gives us the ability to favor Readers (accessing connection stats) over Writers (adding a new connection). We can probably get away with that if we use regular Dictionary with our lock.

Is it possible to provide a repro that demonstrates high CPU utilization so we can profile somehow the different options?

[Xizt]

I see that paddy has already mentioned similar concern on the issue. #1299 (comment)