Skip to content

Conversation

@tkyc
Copy link
Contributor

@tkyc tkyc commented Mar 18, 2024

@codecov
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 50.13%. Comparing base (eae6d7b) to head (65c4d26).
Report is 2 commits behind head on main.

❗ Current head 65c4d26 differs from pull request most recent head f056aa7. Consider uploading reports for the commit f056aa7 to get more accurate results

Files Patch % Lines
.../microsoft/sqlserver/jdbc/SQLServerXAResource.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2348       +/-   ##
=============================================
- Coverage     73.56%   50.13%   -23.43%     
+ Complexity     6079     3790     -2289     
=============================================
  Files           143      143               
  Lines         33179    33146       -33     
  Branches       5631     5620       -11     
=============================================
- Hits          24407    16619     -7788     
- Misses         6255    14143     +7888     
+ Partials       2517     2384      -133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffery-Wasty
Copy link
Contributor

Also removed unused getRootCause in Util.java (+java.util.List and java.util.ArrayList imports needed for it) (added in 2nd XA PR [#2132])

@tkyc tkyc merged commit 41710d2 into main Mar 19, 2024
@tkyc tkyc deleted the default-rmfail branch March 19, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed/Merged PRs

Development

Successfully merging this pull request may close these issues.

XAER_RMERR still being thrown during SQL Server failover with 12.5.0 despite fixes for issues 2130 and 2159

4 participants