Skip to content

Conversation

@tkyc
Copy link
Contributor

@tkyc tkyc commented Mar 25, 2024

Reverts #2324

@codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.04%. Comparing base (9a13e5d) to head (236ec27).

❗ Current head 236ec27 differs from pull request most recent head fe7f3ff. Consider uploading reports for the commit fe7f3ff to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2365      +/-   ##
============================================
- Coverage     50.06%   50.04%   -0.03%     
+ Complexity     3810     3807       -3     
============================================
  Files           145      145              
  Lines         33304    33286      -18     
  Branches       5641     5639       -2     
============================================
- Hits          16675    16657      -18     
+ Misses        14245    14242       -3     
- Partials       2384     2387       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkyc
Copy link
Contributor Author

tkyc commented Mar 25, 2024

@vxel

After more testing with Always Encrypted. It looks like it's erroring out with:

The incoming tabular data stream (TDS) remote procedure call (RPC) protocol stream is incorrect. Parameter 5 (""): Data type 0x00 is unknown.

The test that failed was testOutputProcedureCharInorder. Sorry that this wasn't more extensively tested before the merge. We'll need to look more into this.

@lilgreenbird lilgreenbird added this to the 12.7.0 milestone Mar 25, 2024
@lilgreenbird lilgreenbird merged commit 8e92248 into main Mar 25, 2024
@Jeffery-Wasty Jeffery-Wasty deleted the revert-2324-feature/1582 branch March 25, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed/Merged PRs

Development

Successfully merging this pull request may close these issues.

4 participants