Skip to content

Conversation

@lilgreenbird
Copy link
Contributor

No description provided.

@lilgreenbird lilgreenbird added this to the 12.7.1 milestone May 14, 2024
@codecov
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.11%. Comparing base (2a25d8f) to head (3c51080).
Report is 1 commits behind head on main.

Current head 3c51080 differs from pull request most recent head ff656e2

Please upload reports for the commit ff656e2 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2416      +/-   ##
============================================
- Coverage     50.24%   50.11%   -0.13%     
+ Complexity     3843     3832      -11     
============================================
  Files           145      145              
  Lines         33355    33355              
  Branches       5654     5654              
============================================
- Hits          16758    16717      -41     
- Misses        14205    14239      +34     
- Partials       2392     2399       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffery-Wasty
Copy link
Contributor

Jeffery-Wasty commented May 17, 2024

Also can you remove the comment in SharedTimerTest::32,33.

tkyc
tkyc previously approved these changes May 21, 2024
tkyc
tkyc previously approved these changes May 21, 2024
Jeffery-Wasty
Jeffery-Wasty previously approved these changes May 21, 2024
@lilgreenbird lilgreenbird dismissed stale reviews from Jeffery-Wasty and tkyc via ff656e2 May 21, 2024 22:30
@lilgreenbird lilgreenbird merged commit a35798e into main May 21, 2024
@Jeffery-Wasty Jeffery-Wasty deleted the secrets branch May 22, 2024 19:23
tkyc added a commit that referenced this pull request May 23, 2024
* Updates for running tests with managed identity (#2416)

* Updated tests for removal of secrets

* Reverted TimeoutTests

* AE config port

* TimeoutTests update

---------

Co-authored-by: lilgreenbird <[email protected]>
Jeffery-Wasty pushed a commit that referenced this pull request Jan 28, 2025
Signed-off-by: Jeff Wasty <[email protected]>

# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/TestResource.java
#	src/test/java/com/microsoft/sqlserver/jdbc/TestUtils.java
#	src/test/java/com/microsoft/sqlserver/jdbc/connection/TimeoutTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetaDataTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java
Jeffery-Wasty added a commit that referenced this pull request Jan 28, 2025
Jeffery-Wasty added a commit that referenced this pull request Jan 28, 2025
Jeffery-Wasty added a commit that referenced this pull request Mar 19, 2025
…date (#2602)

* Update build.gradle

* Update pom.xml

* Update pom.xml

* Update pom.xml

* Update pom.xml

* Update pom.xml

* Update pom.xml

* Update pom.xml

* ManagedIdentity I

Signed-off-by: Jeff Wasty <[email protected]>

* Updates for running tests with managed identity (#2416)

Signed-off-by: Jeff Wasty <[email protected]>

# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/TestResource.java
#	src/test/java/com/microsoft/sqlserver/jdbc/TestUtils.java
#	src/test/java/com/microsoft/sqlserver/jdbc/connection/TimeoutTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetaDataTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java

* Delete mistakenly added files

* Delete mistakenly added files

* Revert "Delete mistakenly added files"

This reverts commit 19abc22.

* Revert "Delete mistakenly added files"

This reverts commit 04f8c82.

* Revert "Updates for running tests with managed identity (#2416)"

This reverts commit b727a96.

* Revert "ManagedIdentity I"

This reverts commit 6d5c519.

* Delete garbage

* Fixed Managed Identity tests (#1935)

Signed-off-by: Jeff Wasty <[email protected]>

# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/MSITest.java

* Managed Identity dev experience improvements #1936

Signed-off-by: Jeff Wasty <[email protected]>

* Updates for running tests with managed identity #2416

Signed-off-by: Jeff Wasty <[email protected]>

* cleanup

Signed-off-by: Jeff Wasty <[email protected]>

* Update tests for Kerberos

Signed-off-by: Jeff Wasty <[email protected]>

* Remove unused test

* tsc=true for ae

Signed-off-by: Jeff Wasty <[email protected]>

* Add tags for testDefaultRetry

* Remove unstable test

Signed-off-by: Jeff Wasty <[email protected]>

* Add throttling error message to tests (#2044)

Signed-off-by: Jeff Wasty <[email protected]>

* Updated fedauth tests to run on diff test server (#2062)

Signed-off-by: Jeff Wasty <[email protected]>

* Update fedauth tests to use cached tokens and retry if throttled (#2077)

Signed-off-by: Jeff Wasty <[email protected]>

* Add back missing import

Signed-off-by: Jeff Wasty <[email protected]>

* Resolve static issue with IOBuffer

Signed-off-by: Jeff Wasty <[email protected]>

* Add back a missing import

* Fixed TestUtils

* Remove mistakenly added code

* Cleanup

* Cleanup testutils

* More cleanup

* Add more time for 'testDefaultRetry' &
Fix tests for testing encrypt options (#2215)

* Update setAEConnectionString

* Updated fedauth error tests (#2538)

Signed-off-by: Jeff Wasty <[email protected]>

# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/fedauth/ErrorMessageTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/fedauth/FedauthCommon.java

* Update fedAuth tests

* Revert "Updated fedauth error tests (#2538)"

This reverts commit dfb4b77.

* Revert "Update fedAuth tests"

This reverts commit da5c58b.

* Added ActiveDirectoryServicePrincipalCertificate for tests

* Add 'requireSecret' exclude tag for tests which require adding a secret to app registration

* Version update

* Add connection retry changes from 2513 to ensure existing timing tests pass

* Adjust timings on tests as the fix requires code changes we should not incorporate for this release

* Changelog

* Update dependency versions

---------

Signed-off-by: Jeff Wasty <[email protected]>
Co-authored-by: lilgreenbird <[email protected]>
Co-authored-by: Terry Chow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed/Merged PRs

Development

Successfully merging this pull request may close these issues.

4 participants