Fixed timestamp string conversion error for cstmt #2449
Merged
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jeffery-Wasty
left a comment
Jeffery-Wasty
left a comment
There was a problem hiding this comment.
Also, formatter has some suggestions for CallableStatementTest.java.
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2449 +/- ##
============================================
+ Coverage 50.13% 50.85% +0.72%
- Complexity 3842 3907 +65
============================================
Files 145 145
Lines 33409 33411 +2
Branches 5667 5668 +1
============================================
+ Hits 16750 16992 +242
+ Misses 14258 14022 -236
+ Partials 2401 2397 -4 ☔ View full report in Codecov by Sentry. |
lilgreenbird
approved these changes
Jun 17, 2024
Jeffery-Wasty
approved these changes
Jun 17, 2024
tkyc
added a commit
that referenced
this pull request
Jun 19, 2024
* Fixed timestamp string conversion error for cstmt * Code review comments p1 * Fixed sproc used in test
This was referenced Jun 19, 2024
Jeffery-Wasty
added a commit
that referenced
this pull request
Jun 20, 2024
* Fixed timestamp string conversion error for cstmt * Code review comments p1 * Fixed sproc used in test Co-authored-by: Jeff Wasty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2436.