openhcl/threadpool: fix sidecar spawn when threadpool is already started #2070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the threadpool is already running for a given VP because of a spawned thread, the code to online a sidecar vp incorrectly issues a cancel before
run_vp
is called, which results in an assertion failure due to unexpected saved state as the firstrun_vp
call will exit with a user cancel. Fix this by adding a new boolean field to the notifier closure that the threadpool and other callers can use to indicate if the threadpool called the notifier, or something else.This occurs when keep-alive is enabled, as the nvme manager has state to restore which will spawn a task on the remote VP that is currently running sidecar due to nvme being restored before vp_set. Reenable sidecar with keep alive tests now that this is fixed.
Fixes #1345.