vmm_tests: Adds a regression test to verify that duplicate aer requests are not sent after servicing with keepalive. #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a regression test to verify that duplicate Asynchronous Event Request (AER) commands are not sent to an NVMe controller after servicing with keepalive enabled. The test ensures that when an AER is already pending, the driver doesn't incorrectly send another one.
Key changes:
- Refactored existing servicing tests to use a common helper function
apply_fault_with_keepalive - Added a new test
servicing_keepalive_verify_no_duplicate_aersthat panics if duplicate AER commands are detected during servicing - Consolidated duplicate test setup logic into a reusable function
gurasinghMS
force-pushed
the
single-aer-only-test
branch
from
92ffa3e to
1070675
Compare
mattkur
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a regression test to verify that the driver does not issue additional AERs after restore if something is already pending. Also some minor restructuring of tests.