Skip to content

Conversation

mattkur
Copy link
Contributor

@mattkur mattkur commented Oct 10, 2025

While debugging some failures to modify VTL2 settings, I noticed that we didn't have explicit logging in some error paths. Add that logging.

@mattkur mattkur requested review from a team and Copilot and removed request for a team October 10, 2025 22:46
@mattkur mattkur requested a review from a team as a code owner October 10, 2025 22:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds explicit tracing/logging statements to improve debugging capabilities in the VTL2 settings worker. The changes provide better visibility into error paths that previously lacked explicit logging.

  • Added trace logging for received VTL2 settings
  • Added warning logs for errors during VTL2 configuration preparation and application phases
  • Refactored settings parsing logic to enable intermediate logging

@mattkur mattkur requested a review from a team October 10, 2025 22:48
Copy link
Contributor

@smalis-msft smalis-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is that this error probably gets logged upstream, but this is goodness too, especially if they aren't actually logged upstream.

@mattkur
Copy link
Contributor Author

mattkur commented Oct 10, 2025

I think the idea is that this error probably gets logged upstream, but this is goodness too, especially if they aren't actually logged upstream.

I think so too. But I'm going to hold off merging this one until I fully understand what's going on. I had errors, yet I saw no error logs.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants