nvme: todo comment cleanup/new devnote #2211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs cleanup of NVMe-related comments based on exploration done in #2087. The changes remove outdated TODO comments and add clarifying documentation about NVMe state management behavior.
- Removes an outdated TODO comment about allocation detection and degraded state handling
- Adds a developer note explaining the correlation between NVMe state saving and keepalive functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vm/devices/storage/disk_nvme/nvme_driver/src/queue_pair.rs | Removes outdated TODO comment about allocation characteristics detection |
| openhcl/underhill_core/src/dispatch/mod.rs | Adds DEVNOTE explaining NVMe state saving behavior and its relationship to teardown operations |
smalis-msft
approved these changes
Oct 20, 2025
Contributor
|
Test failure here is known tdx flakiness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I explored the problem space for dealing with allocation characteristics in #2087. I've split
out a few PRs from this, and added tests to verify that the driver behaves as expected (see #2206).
All that's left is a couple behavioral comment updates. Those are included here.