Skip to content

chore(list reporter): align test index #36779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Jul 24, 2025

Padding the test index to the same length helps me with scanning the test output.

Before:

 npx playwright test integration

Running 75 tests using 6 workers

    1 [chromium]  tests/integration.spec.ts:104:7  Mark all as completed  should allow me to clear the complete state of all items (1.4s)
    2 [chromium]  tests/integration.spec.ts:57:7  New Todo  should append new items to the bottom of the list (1.3s)
    3 [chromium]  tests/integration.spec.ts:95:7  Mark all as completed  should allow me to mark all items as completed (1.4s)
    4 [chromium]  tests/integration.spec.ts:44:7  New Todo  should clear text input field when an item is added (1.3s)
    5 [chromium]  tests/integration.spec.ts:19:7  New Todo  should allow me to add todo items (1.3s)
    6 [chromium]  tests/integration.spec.ts:72:7  New Todo  should show #main and #footer when items added (1.3s)
    7 [chromium]  tests/integration.spec.ts:114:7  Mark all as completed  complete all checkbox should update state when items are completed / cleared (1.2s)
    8 [chromium]  tests/integration.spec.ts:137:7  Item  should allow me to mark items as complete (1.2s)
    9 [chromium]  tests/integration.spec.ts:162:7  Item  should allow me to un-mark items as complete (1.2s)
    10 [chromium]  tests/integration.spec.ts:185:7  Item  should allow me to edit an item (1.2s)
    11 [chromium]  tests/integration.spec.ts:211:7  Editing  should hide other controls when editing (1.0s)
    12 [chromium]  tests/integration.spec.ts:221:7  Editing  should save edits on blur (1.1s)
    13 [chromium]  tests/integration.spec.ts:235:7  Editing  should trim entered text (1.0s)
    14 [chromium]  tests/integration.spec.ts:249:7  Editing  should remove the item if an empty text string was entered (1.1s)
    15 [chromium]  tests/integration.spec.ts:261:7  Editing  should cancel edits on escape (1.0s)
    16 [chromium]  tests/integration.spec.ts:271:7  Counter  should display the current number of todo items (978ms)
    17 [chromium]  tests/integration.spec.ts:292:7  Clear completed button  should display the correct text (1.0s)
    18 [chromium]  tests/integration.spec.ts:297:7  Clear completed button  should remove completed items when clicked (1.1s)
    19 [chromium]  tests/integration.spec.ts:305:7  Clear completed button  should be hidden when there are no items that are completed (1.0s)
...

After:

 npx playwright test

Running 75 tests using 6 workers

     1 [chromium]  tests/integration.spec.ts:44:7  New Todo  should clear text input field when an item is added (1.2s)
     2 [chromium]  tests/integration.spec.ts:95:7  Mark all as completed  should allow me to mark all items as completed (1.2s)
     3 [chromium]  tests/integration.spec.ts:19:7  New Todo  should allow me to add todo items (1.2s)
     4 [chromium]  tests/integration.spec.ts:72:7  New Todo  should show #main and #footer when items added (1.1s)
     5 [chromium]  tests/integration.spec.ts:104:7  Mark all as completed  should allow me to clear the complete state of all items (1.3s)
     6 [chromium]  tests/integration.spec.ts:57:7  New Todo  should append new items to the bottom of the list (1.2s)
     7 [chromium]  tests/integration.spec.ts:114:7  Mark all as completed  complete all checkbox should update state when items are completed / cleared (1.2s)
     8 [chromium]  tests/integration.spec.ts:137:7  Item  should allow me to mark items as complete (1.2s)
     9 [chromium]  tests/integration.spec.ts:162:7  Item  should allow me to un-mark items as complete (1.2s)
    10 [chromium]  tests/integration.spec.ts:185:7  Item  should allow me to edit an item (1.1s)
    11 [chromium]  tests/integration.spec.ts:211:7  Editing  should hide other controls when editing (1.0s)
    12 [chromium]  tests/integration.spec.ts:221:7  Editing  should save edits on blur (992ms)
    13 [chromium]  tests/integration.spec.ts:235:7  Editing  should trim entered text (1.1s)
    14 [chromium]  tests/integration.spec.ts:249:7  Editing  should remove the item if an empty text string was entered (1.0s)
    15 [chromium]  tests/integration.spec.ts:261:7  Editing  should cancel edits on escape (1.1s)
    16 [chromium]  tests/integration.spec.ts:271:7  Counter  should display the current number of todo items (949ms)
    17 [chromium]  tests/integration.spec.ts:292:7  Clear completed button  should display the correct text (998ms)
    18 [chromium]  tests/integration.spec.ts:297:7  Clear completed button  should remove completed items when clicked (1.0s)
    19 [chromium]  tests/integration.spec.ts:305:7  Clear completed button  should be hidden when there are no items that are completed (1.1s)
...

This comment has been minimized.

@agg23
Copy link
Contributor

agg23 commented Jul 25, 2025

I love it, though I think the spacing should be before the ordinal, not after. Additionally, it begs the question of why we don't do similar spacing on the other sections (it makes less sense to do so, but consistency...).

@Skn0tt
Copy link
Member Author

Skn0tt commented Jul 25, 2025

the spacing should be before the ordinal, not after

good point! will change it.

it begs the question of why we don't do similar spacing on the other sections

yup, I wondered the same. I guess we could do it for project names like "chromium", "webkit", "firefox" because they're all similarly long and we don't loose much space because of it. but the more variance amongst the segment lengths, the bigger is the waste of space.

Copy link
Contributor

Test results for "tests 1"

3 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:157:5 › mobile viewport › mouse should work with mobile viewports and cross process navigations @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

46501 passed, 804 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants