Skip to content

chore: retry stable browsers up to 3 times #36789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt requested a review from Skn0tt July 25, 2025 12:20
Copy link
Contributor

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node24
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-trace.spec.ts:587:5 › should indicate current test status @macos-latest-node18-1
⚠️ [webkit-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

46498 passed, 804 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going by the cURL docs, --retry only retries transient errors: https://curl.se/docs/manpage.html#--retry

I'm not sure if "Empty reply from server" is a transient error, at least it's not in the list. It looks like there's --retry-connrefused to add one more error type to the retry, but that also doesn't read like "Empty reply from server". Let's try merging this to see if it helps, but I wouldn't be surprised if it doesn't :D

@mxschmitt mxschmitt merged commit 18f147a into microsoft:main Jul 28, 2025
32 checks passed
@mxschmitt mxschmitt deleted the retry-channel-browsers branch July 28, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants