-
Notifications
You must be signed in to change notification settings - Fork 4.4k
chore(test): fix Codegen "should save assets via SIGINT" #36798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 failed 3 flaky46500 passed, 804 skipped Merge workflow run. |
Test results for "tests others"1 fatal errors, not part of any test Merge workflow run. |
Test results for "tests 2"8 fatal errors, not part of any test 131 flaky239960 passed, 9548 skipped Merge workflow run. |
I think there is an underlying cause, I don't remember what it is, but it is not easy. |
I'm unsure if we consider it acceptable for a forceful termination of the browser during this test, but that's what is happening in these test failures. Consider exit code 1 acceptable.