Skip to content

Fix transforms #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 26, 2022
Merged

Fix transforms #1035

merged 6 commits into from
Feb 26, 2022

Conversation

@Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Feb 21, 2022 •
edited
Loading

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This picks up where #280 and #460 left off, fixing animations on macOS.

Changelog

[macOS] [Fixed] - Fixed 3D Transforms not working properly

Test Plan

RN-Tester's transform page look identical on both iOS and macOS

Screen Shot 2022-02-25 at 12 24 55 PM

@Saadnajmi Saadnajmi requested a review from a team as a code owner February 21, 2022 20:44
@Saadnajmi Saadnajmi mentioned this pull request Feb 25, 2022
Closed
4 tasks
@Saadnajmi Saadnajmi changed the title [Draft] Fix transforms Fix transforms Feb 25, 2022
harrieshin
harrieshin reviewed Feb 25, 2022
View reviewed changes
harrieshin
harrieshin reviewed Feb 25, 2022
View reviewed changes
@Saadnajmi Saadnajmi merged commit e7cfa13 into microsoft:main Feb 26, 2022
@Saadnajmi Saadnajmi deleted the fix-transforms-new branch February 26, 2022 03:33
Saadnajmi added a commit to Saadnajmi/react-native-macos that referenced this pull request Feb 27, 2022
@Saadnajmi @sahrens
Fix transforms (microsoft#1035)
1d576f1 
* fix transforms microsoft#280

* remove duplicate

* fix errors

* Update from PR feedback

Co-authored-by: Spencer Ahrens <[email protected]>
@Saadnajmi Saadnajmi mentioned this pull request Feb 27, 2022
Merged
@jdk
Copy link

jdk commented Feb 28, 2022 •
edited
Loading

@Saadnajmi We did some testing and this looks great, thank you.

@Saadnajmi
Copy link
Collaborator Author

Saadnajmi commented Feb 28, 2022

@Saadnajmi We did some testing and this looks great, thank you.

Thanks! It should be included in the next patch release of rn-macOS 0.66 =)

Saadnajmi added a commit that referenced this pull request Feb 28, 2022
@Saadnajmi @sahrens
[0.66] Cherry pick Transforms fix and CI fix (#1058)
874bd4e 
* Fix transforms  (#1035)

* fix transforms #280

* remove duplicate

* fix errors

* Update from PR feedback

Co-authored-by: Spencer Ahrens <[email protected]>

* Disable failing CircleCI test (#1052)

* Disable circleci test

* Disable another test

Co-authored-by: Spencer Ahrens <[email protected]>
@Saadnajmi Saadnajmi mentioned this pull request Aug 9, 2022
Closed
@Saadnajmi Saadnajmi mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harrieshin harrieshin harrieshin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Saadnajmi @jdk @harrieshin @sahrens