Revert Flatlist changes #1306
Merged
Revert Flatlist changes #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
approved these changes
Jul 29, 2022
chiuam
changed the title
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 24, 2022
This reverts commit 8ce9545.
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 25, 2022
This reverts commit 8ce9545.
4 tasks
Saadnajmi
added a commit
that referenced
this pull request
Aug 26, 2022
…1375) * Revert "Revert Flatlist changes (#1306)" This reverts commit 8ce9545. * Refactor handling of keyDown/keyUp (#1338) This refactors / simplifies certain keyUp|Down event handling. It will make a later change (adding textInput handling for textInput fields) easier (to review) Co-authored-by: Scott Kyle <[email protected]> * Deprecate onScrollKeyDown, refactor Flatlist selection logic (#1365) * Deprecate onScrollKeyDown remove pressable diff Remove JS handling for PageUp/Down, fix flow errors Add back "autoscroll to focused view" behavior remove commented code remove change to pressable Update documentation fix flow error fix lint issue Fix 'selectRowAtIndex' More simplification lock * Make method public again * Add initialSelectedIndex * macOS tags * fix lint * remove one more reference * yarn lint --fix * RNTester: only show the Flatlist keyboard navigation switch on macOS Co-authored-by: Christoph Purrer <[email protected]> Co-authored-by: Scott Kyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1269