fix: dismiss all sheets created by RCTDevLoadingView when hide is called
#2448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
commented
Mar 29, 2025
Saadnajmi
changed the title
[RCTDevLoadingView hide] is calledRCTDevLoadingView when hide is called
JunielKatarn
approved these changes
Apr 8, 2025
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Apr 8, 2025
… called (microsoft#2448) ## Summary: We've had a recurring bug where `RCTDevLoadingView` stick around blocking the whole app even after it's dismissed. As far as I can tell, this is a race condition where we have multiple devloadingviews at once (each setting and nilling the same `self->_window` property), which is causing a race condition. Rather than figure out how to make this class only ever show one window or race-safe, for now I will just make sure to dismiss _all_ sheets when `hide` is called. While we're at it, a couple of other changes: 1. Change the type from `NSPanel` to `NSWindow`. Panels don't release when closed, which may be causing them to stick around longer than we like 2. Move the iOS only variable `mainWindow` into the iOS ifdef, and remove the diffs and diff tag around it. ## Test Plan: Initial testing shows RNTester no longer getting blocked. It could still happen (race conditions are hard), but I think the change is safe to add regardless.
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Apr 8, 2025
… called (microsoft#2448) ## Summary: We've had a recurring bug where `RCTDevLoadingView` stick around blocking the whole app even after it's dismissed. As far as I can tell, this is a race condition where we have multiple devloadingviews at once (each setting and nilling the same `self->_window` property), which is causing a race condition. Rather than figure out how to make this class only ever show one window or race-safe, for now I will just make sure to dismiss _all_ sheets when `hide` is called. While we're at it, a couple of other changes: 1. Change the type from `NSPanel` to `NSWindow`. Panels don't release when closed, which may be causing them to stick around longer than we like 2. Move the iOS only variable `mainWindow` into the iOS ifdef, and remove the diffs and diff tag around it. ## Test Plan: Initial testing shows RNTester no longer getting blocked. It could still happen (race conditions are hard), but I think the change is safe to add regardless.
This was referenced Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We've had a recurring bug where
RCTDevLoadingViewstick around blocking the whole app even after it's dismissed. As far as I can tell, this is a race condition where we have multiple devloadingviews at once (each setting and nilling the sameself->_windowproperty), which is causing a race condition. Rather than figure out how to make this class only ever show one window or race-safe, for now I will just make sure to dismiss all sheets whenhideis called.While we're at it, a couple of other changes:
NSPaneltoNSWindow. Panels don't release when closed, which may be causing them to stick around longer than we likemainWindowinto the iOS ifdef, and remove the diffs and diff tag around it.Test Plan:
Initial testing shows RNTester no longer getting blocked. It could still happen (race conditions are hard), but I think the change is safe to add regardless.