-
Notifications
You must be signed in to change notification settings - Fork 151
Implementing AccessibilityInfo.DisplayOptions ex: isInvertColorsEnabled #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing AccessibilityInfo.DisplayOptions ex: isInvertColorsEnabled #455
Conversation
analysis-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis results:
eslintfound some issues. Runyarn lint --fixto automatically fix problems.
|
Uh, oh. The macOS CI tests crashed in the AccessiblityExample LoadAllPages tests. https://dev.azure.com/ms/react-native/_build/results?buildId=88462&view=logs&j=628dfcdf-afa5-5702-e4da-dfa310a93062&t=65c699ef-104f-5f6e-4efa-350cb1662389. You can run the test locally: Cmd+U to run all the test, then you can manually re-run the LoadAllPages tests by clicking the little run arrow on that test. The only guess I have as to why its crashing is because you're not unobserving the notification in the dealloc. |
analysis-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis results:
eslintfound some issues. Runyarn lint --fixto automatically fix problems.
Please select one of the following
Summary
When the MacOS fork was made all the AccessibilityInfo functionality was stubbed out because the iOS Accessibility APIs are different from the MacOS APIs. I am implementing several AccessibilityInfo properties and EvenListeners. This will allow a application to tell if several Accessible Display Options are enabled, or if they change.
Specifically this PR implements AccessibilityInfo.isInvertColorsEnabled AccessibilityInfo.isReduceMotionEnabled and AccessibilityInfo.isReduceTransparencyEnabled.
Changelog
[MacOS] [Added] - Implemented AccessibilityInfo.isInvertColorsEnabled, isReduceMotionEnabled, & isReduceTransparencyEnabled
Test Plan
Microsoft Reviewers: Open in CodeFlow