Fix onFocus/onBlur event bubbling in 0.60 stable #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update scripts to publish react-native-macos-init * Clean up merge markers * Restored ios:macos RNTester parity except for InputAccessoryView. * Revert "Restored ios:macos RNTester parity except for InputAccessoryView." This reverts commit 5a67ae0. * Remove unnecessary android builds and tar file upload. * Fix onFocus/onBlur View events to properly bubble. * The Text component can also be selectable={true} and needs the same focus/blur event triggering as View. Co-authored-by: React-Native Bot <[email protected]>
|
HeyImChris
approved these changes
Jul 21, 2020
HeyImChris
pushed a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Aug 17, 2020
* Fix onFocus/onBlur event bubbling (microsoft#506) * Update scripts to publish react-native-macos-init * Clean up merge markers * Restored ios:macos RNTester parity except for InputAccessoryView. * Revert "Restored ios:macos RNTester parity except for InputAccessoryView." This reverts commit 5a67ae0. * Remove unnecessary android builds and tar file upload. * Fix onFocus/onBlur View events to properly bubble. * The Text component can also be selectable={true} and needs the same focus/blur event triggering as View. Co-authored-by: React-Native Bot <[email protected]> * Added new RCTFocusChangeEvent to static xcodeproj's * Change vmImage to ubuntu-latest for Android builds. Co-authored-by: React-Native Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This is the same PR made to master #506 cherry-picked into the 0.60-stable branch.
It fixes
onFocus/onBlurevents on<View>and<TextView>components so that the events bubble up the component hierarchy in the same way they do on the web and on react-native-windows.Besides just the cherry-pick of the commit on master, the static xcodeproj's that no longer exist in master had to be updated with references to the new
RCTFocusChangeEvent.m/hfile.Changelog
[macOS] [Fixed] - Fix onFocus/onBlur event bubbling in 0.60 stable
Test Plan
The existing
FocusEventExamplewas extended to include examples using<Text>elements,<Buttons>, and cases where theonFocusandonBlurhandlers were on various combinations of ancestor components, the focusable components themselves and both.Microsoft Reviewers: Open in CodeFlow