Skip to content

Conversation

@harinikmsft
Copy link

@harinikmsft harinikmsft commented Aug 4, 2020

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Added issue templates to the macOS repo mimicking the Windows repo for feature requests and module requests specific to macOS requests. There are a few new feature requests coming up from customers like Messenger that would benefit from having templates made available in this repo. This is to help that.

Microsoft Reviewers: Open in CodeFlow

@harinikmsft harinikmsft requested a review from tom-un as a code owner August 4, 2020 20:42
@harinikmsft harinikmsft requested a review from chrisglein August 4, 2020 20:42
@pull-bot
Copy link

pull-bot commented Aug 4, 2020

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against a6e8853

@harinikmsft harinikmsft requested a review from acoates-ms August 4, 2020 22:02
@harinikmsft harinikmsft merged commit 072283d into microsoft:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants