-
Notifications
You must be signed in to change notification settings - Fork 151
Make "Snapshot/Screenshot" test page works #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alloy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Xcode land 😄
One thing that isn’t immediately clear to me is why this is using Turbo Modules; is it just forward thinking or did you take this module as an entry-point to start your larger work effort on Turbo Modules in RN macOS?
alloy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this seems good to me 👍
The one thing I’m wondering now is if we should wait to merge this into master until we’ve released v0.62 proper (currently still in prerelease), or perhaps you can create a new macos-turbo-modules branch and merge these changes there, an merge all of that work into master later on?
/cc @acoates-ms
analysis-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis results:
eslintfound some issues. Runyarn lint --fixto automatically fix problems.
Please select one of the following
Summary
Snapshot/Screenshotpage is originally designed for taking a screenshot from the main window in iOS using NativeModule.Changelog
[macOS] [Fixed] - Make "Snapshot/Screenshot" test page works.
Test Plan
Manually tested.
Microsoft Reviewers: Open in CodeFlow