Skip to content

Conversation

@mganandraj
Copy link

@mganandraj mganandraj commented Mar 10, 2021

This fix will avoid flattening null to '0' when resetting color properties of Image.

I create this PR to upstream this change. But later realized there is another active PR for this issue with similar fix.

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This fix will avoid flattening null to '0' when resetting color properties of Image.

Changelog

This fix will avoid flattening null to '0' when resetting color properties of Image.

[CATEGORY] [TYPE] - Message

Test Plan

Tested.

Microsoft Reviewers: Open in CodeFlow

@mganandraj mganandraj requested a review from alloy as a code owner March 10, 2021 03:51
@mganandraj mganandraj requested review from a team and acoates-ms March 10, 2021 03:53
@pull-bot
Copy link

pull-bot commented Mar 10, 2021

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 4e5f6b0

@acoates-ms
Copy link
Collaborator

@mganandraj Lets make sure we have a bug tracking 0.64/master to ensure that we get either this or the other PR into master. That can presumably wait until we see which PR gets into FB master.

Going to push this one in since we want it internally quickly.

@HeyImChris
Copy link

HeyImChris commented Mar 10, 2021

@mganandraj Lets make sure we have a bug tracking 0.64/master to ensure that we get either this or the other PR into master. That can presumably wait until we see which PR gets into FB master.

Going to push this one in since we want it internally quickly.

The Apple failure is something I've seen before. It looks like your pod file is out of date. Shouldn't matter for this change as you didn't touch Apple files but just an fyi on what's going on there

@acoates-ms acoates-ms merged commit f27bd11 into microsoft:0.63-stable Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants