Skip to content

Conversation

@HeyImChris
Copy link

Please select one of the following

  • I am making a change required for Microsoft usage of react-native

Summary

Some downstream dependencies have non null checks that fail here if we don't tag appropriately. This is also a virtuous change as it adds clarity to the method header.

Changelog

[Bug] [iOS/macOS] - Nonnull compatibility check

Test Plan

No functional change

@HeyImChris HeyImChris requested a review from alloy as a code owner November 4, 2021 17:17
@pull-bot
Copy link

pull-bot commented Nov 4, 2021

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 0c9b4fc

@acoates-ms acoates-ms changed the title Fix nonnull compat issue [0.64] Fix nonnull compat issue Nov 4, 2021
@HeyImChris HeyImChris merged commit 3bf2fda into microsoft:0.64-stable Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants