Remove unnecessary overrides to onFocus and onBlur in Pressable
#10942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
changed the title
onFocus and onBlur in Pressable. onFocus and onBlur in Pressable
10 tasks
rurikoaraki
approved these changes
Dec 14, 2022
Saadnajmi
changed the title
onFocus and onBlur in PressableonFocus and onBlur in Pressable
Saadnajmi
added a commit
to Saadnajmi/react-native-windows
that referenced
this pull request
Dec 15, 2022
…icrosoft#10942) * Remove unneccesary overrides * Change files * Add test
Saadnajmi
added a commit
to Saadnajmi/react-native-windows
that referenced
this pull request
Dec 15, 2022
…icrosoft#10942) * Remove unneccesary overrides * Change files * Add test
Saadnajmi
added a commit
to Saadnajmi/react-native-windows
that referenced
this pull request
Dec 15, 2022
…icrosoft#10942) * Remove unneccesary overrides * Change files * Add test
Saadnajmi
added a commit
to Saadnajmi/react-native-windows
that referenced
this pull request
Dec 15, 2022
…icrosoft#10942) * Remove unneccesary overrides * Change files * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove some legacy code that unnecessarily overrides
onBlurandonFocusin PressableType of Change
Why
As far as I can tell, we were unnecessarily overriding
onFocusandonBlurin the desktop Pressable forks. This (may) have caused Pressable to fail shallow compare and re-render unnecessarily, affecting downstream components in FluentUI React Native. Those specific event handlers are already handled inPressability.jsand passed into Pressable via the{...eventHandlers}spread across React Native Core, windows, and macOS.What
What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
Screenshots
Add any relevant screen captures here from before or after your changes.
Testing
Tested in Playground.
playground.2022-12-11.20-30-55.mp4
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow