-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix init-windows template to automatically detect existing codegen spec files #15096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: anupriya13 <[email protected]>
@copilot don't add a comment for developer to fix, we need to get the correct file name from |
…dcoded names Co-authored-by: anupriya13 <[email protected]>
I've updated the solution to automatically detect existing codegen spec files instead of using TODO comments. The template now:
This eliminates the need for manual developer intervention while handling both scenarios correctly. (commit b02696d) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
#include "codegen/Native{{ pascalName }}DataTypes.g.h" | ||
#endif | ||
#include "codegen/Native{{ pascalName }}Spec.g.h" | ||
{{#hasExistingSpecFiles}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Please add a preceding comment about these Mustache template nuances as these are foreign to regular C++ programmers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added explanatory comments about the Mustache template syntax before both conditional include blocks to help C++ developers understand that these constructs will be processed during project generation. (commit a098073)
…opers Co-authored-by: sundaramramaswamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Microsoft Reviewers: Open in CodeFlow