Conditional range #617
Merged
Conditional range #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This range allows for a contained range to be disabled at runtime. This allows for thread local caching to be disabled if the initial fixed size heap is below a threshold.
nwf-msr
reviewed
Jun 8, 2023
| // and uses the ancestor functions to bypass the OptionalRange if the flag | ||
| // has been set. | ||
| template<typename ParentRange> | ||
| class Type : public ContainsParent<Pipe<ParentRange, OptionalRange>> |
There was a problem hiding this comment.
I've nothing to add here except to quote Hackers:
It's so neat and clean.
Doesn't look like a hacker wrote it.
There was a problem hiding this comment.
Now I need to watch "Hackers" ;)
nwf-msr
reviewed
Jun 20, 2023
nwf-msr
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new type of Range that can allow a range to be disabled dynamically.
This is used to disable some backend caching if the heap is very small, such as in the OpenEnclave case.