Fixes #1918 - Added docs for image/icon settings & paths #2545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Described URI Schemes & their use * Added guidance re. background images * Added notes re. icons (inc. sizing) * Added example JSON & screenshot of background & icon
bitcrazed
requested review from
DHowett-MSFT and
cinnamon-msft
and removed request for
DHowett-MSFT
bitcrazed
added
the
Issue-Docs
DHowett-MSFT
suggested changes
Aug 26, 2019
ghost
added
Needs-Author-Feedback
Thanks Dustin :) Co-Authored-By: Dustin L. Howett (MSFT) <[email protected]>
Contributor
|
Still reckon you don’t need to be proscriptive and say that the images can be PNG, GIF or JPG. They can be any taster format, and ICO is popular with people migrating from old shortcuts to the new profile system. Know what I mean? |
added 2 commits
August 29, 2019 13:29
* Simplified text * Added some recommendations * Removed redundant text
DHowett-MSFT
approved these changes
Aug 30, 2019
miniksa
approved these changes
Sep 4, 2019
Co-Authored-By: Michael Niksa <[email protected]>
Co-Authored-By: Michael Niksa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Added docs re. Icon and background images. Also added note that Terminal-specified icon URIs should not relied upon and are considered internal implementation detail.
PR Checklist