Skip to content

Modified __rest to check if property is enumerable. #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2019
Merged

Modified __rest to check if property is enumerable. #66

merged 2 commits into from
May 7, 2019

Conversation

@NicholasLYang
Copy link
Contributor

@NicholasLYang NicholasLYang commented Apr 26, 2019

Corresponding PR to TypeScript one. Modifies __rest to include a propertyIsEnumerable check.

rbuckton
rbuckton approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@rbuckton rbuckton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rbuckton rbuckton merged commit 57efce4 into microsoft:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rbuckton rbuckton rbuckton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NicholasLYang @rbuckton