Re-port isUsedInFunctionOrInstanceProperty #1872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-ports the isUsedInFunctionOrInstanceProperty function to fix issue #1870. The refactoring replaces a traditional for-loop traversal with the ast.FindAncestorOrQuit utility function for cleaner code structure and improved maintainability.
Key changes:
- Converted loop-based ancestor traversal to use
ast.FindAncestorOrQuitpattern - Updated return statements to use appropriate
ast.FindAncestorResultvalues - Added a test case to verify blocked scope variable behavior
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/checker/checker.go |
Refactored isUsedInFunctionOrInstanceProperty to use ast.FindAncestorOrQuit instead of manual loop traversal |
testdata/tests/cases/compiler/blockedScopeVariableNotUnused1.ts |
Added test case for blocked scope variable usage validation |
testdata/baselines/reference/compiler/blockedScopeVariableNotUnused1.* |
Generated baseline files for the new test case |
DanielRosenwasser
approved these changes
Oct 10, 2025
Comment on lines
+1921
to
+1922
| initializerOfProperty := propertyDeclaration.Initializer() == current | ||
| if initializerOfProperty { |
Member
There was a problem hiding this comment.
Nit on naming and comparison order to make it more readable
Suggested change
| initializerOfProperty := propertyDeclaration.Initializer() == current | |
| if initializerOfProperty { | |
| currentIsInitializer := current == propertyDeclaration.Initializer() | |
| if currentIsInitializer { |
or if you flip the order, I'd argue you don't need a variable anyway
Suggested change
| initializerOfProperty := propertyDeclaration.Initializer() == current | |
| if initializerOfProperty { | |
| if current == propertyDeclaration.Initializer() { |
Member
Author
There was a problem hiding this comment.
This is 1:1 ported so I don't really want to futz with it.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
GGomez99
pushed a commit
to GGomez99/typescript-go
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1870