Skip to content

Conversation

@jakebailey
Copy link
Member

The original code said:

if (!(isCallExpression(parent) && contains(parent.arguments, child))) {
    return false;
}

This is just a typo.

Fixes #1496

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a porting bug in the isArgumentAndStartLineOverlapsExpressionBeingCalled function where the wrong AST node was being checked for whether it's a call expression.

Key Changes:

  • Corrected the condition to check if parent is a call expression instead of incorrectly checking child

@jakebailey jakebailey enabled auto-merge October 24, 2025 17:23
@jakebailey jakebailey added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 0487292 Oct 24, 2025
22 checks passed
@jakebailey jakebailey deleted the jabaile/fix-1496 branch October 24, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash in textDocument/rangeFormatting

3 participants