-
Notifications
You must be signed in to change notification settings - Fork 1.7k
put standard library file associations in package.json #14002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the missing extensionless system headers?
ccomplex
cfenv
cinttypes
contracts
cstdalign
cstdbool
cstdint
ctgmath
cuchar
debugging
hazard_pointer
hive
inplace_vector
linalg
rcu
simd
text_encoding
Is this for 1.28.3? Or 1.29.0? Seems like 1.29.0 might be better...I was worried about something breaking regarding the language handling. |
Does this change potentially break something contributed by VS Code itself and/or should the change be made in VS Code itself? |
What about the other "languages" fields like "aliases" and "configuration" -- should those be set? Does VS Code set those and/or do we inherit those if we don't set the fields? |
Yes. It looks like I did not include headers removed since their introduction and new C++26 headers. |
VS Code uses
Do you know how to check if that is still inherited? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add the GSL library extensionless files? VS has those added (maybe others?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we generate/update this list of filenames by reading a shared file with VS which also has a similar list of extension less files? We could do that similar to the import-edge-strings script.
Or otherwise, should it manually match VS?
Fixes: #4077
This change disables
C_Cpp.autoAddFilesAssociations
by default and lists the standard headers inpackage.json
to associate them with C++. Other extensionless headers will not get special treatment, but their languageId will still be fixed when a goto definition command is handled.