Small fixes for Fabric Provisioning Telemetry #20228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenastrid1
requested review from
Benjin,
aasimkhan30,
allancascante,
caohai,
kburtram,
lewis-sanchez,
manujoseph85 and
ssreerama
as code owners
PR Changes
|
Benjin
approved these changes
Sep 25, 2025
aasimkhan30
reviewed
Sep 25, 2025
| {}, | ||
| { | ||
| localContainersInitTimeInMs: Date.now() - startTime, | ||
| fabricProvisioningInitTimeInMs: Date.now() - startTime, |
Contributor
There was a problem hiding this comment.
Why don't you use startActivity From telemetry? You can then use end or endFailed to send the final activity status. It does auto time calculation and keep it consistent with other activity based telemetry.
lewis-sanchez
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines