fix: pack fails in monorepo due to duplicate files #1186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
vsce packorvsce lsin a monorepo or workspace setup, duplicate files may appear in the packaged file list leading to pack fail.This is because the internal dependency collection uses the output of:
However, this command always includes the project root directory as the first line of its output. As a result, when we later glob for files in each dependency directory, the root directory is also globbed, causing all files (including those in subdirectories like node_modules in sub packages) to be collected multiple times.
vscode-vsce/src/package.ts
Lines 1671 to 1675 in 294d71b
You can reproduce this at yuzheng14/valype (temporarily it would exist in feat/vscode-extension branch only).