Replace keytar with @napi-rs/keyring/keytar #1202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
This PR is great. A series of nixos packages cannot be compiled due to C++ compilation errors of keytar. （after nix upgrade clang_19 to clang_21) |
|
@xiaoxiangmoe On the Nixpkgs side, we'll have to pin to Clang 20 for awhile because some of the npm packages in Nixpkgs pull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@napi-rs/keyring exposes an entry point that is API compatible with
keytar.@napi-rs/keyringis preferable tokeytarbecause it uses NAPI so prebuilt binaries work for any Node.js version. This plus the lack oflibsecretdependencies makes this package much easier to install.